Code review comment for lp:~mbp/launchpad/612171-diff-generation-spam
Revision history for this message
| Martin Pool (mbp) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
a60fb26
(Get the code!)
> It would be a regression, and regressions are automatically critical. So yes, it wouldn't be high :-)
I think lp's definition of critical is screwy but that's beside the point.
What I meant was: if we had never sent mail about attempts to merge empty branches, I doubt people would be queuing up to ask that we should, in the same way they are repeatedly asking us to stop sending pointless mail.
But, since the empty branch error isn't what bug 612171 and dupes complain about, I will update this branch to treat the pending writes case as a non-user error, and then leave the empty branch cases alone.