Code review comment for lp:~mbp/kanban/718564-edge

Revision history for this message
Jamu Kakar (jkakar) wrote :

[1]

- get_person_assigned_bugs)
+ get_person_assigned_bugs,
+ SERVICE_ROOT)

Would you mind putting the new import on the same line as
get_person_assigned_bugs to match the existing formatting convention,
please?

[2]

 from launchpadlib.launchpad import Launchpad, EDGE_SERVICE_ROOT

The existing EDGE_SERVICE_ROOT import is no longer used. Can you
please remove it?

When you merge, can you please write a merge commit message using the
following format. You can see examples of it in the log for trunk.

"""
Merged $branch-name [r=$reviewer] [f=$bug-number]

$changeset-description
"""

Thanks for cleaning this up, +1!

review: Approve

« Back to merge proposal