Code review comment for lp:~mbp/bzr/trivial

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 8/24/2011 6:37 AM, Martin Pool wrote:
> Martin Pool has proposed merging lp:~mbp/bzr/trivial into lp:bzr.
>
> Requested reviews: bzr-core (bzr-core) Related bugs: Bug #66336 in
> Bazaar: "Unportable test(1) construct"
> https://bugs.launchpad.net/bzr/+bug/66336 Bug #394649 in Bazaar:
> "NameError raising error in ReadVFile.readline()"
> https://bugs.launchpad.net/bzr/+bug/394649 Bug #408814 in Bazaar:
> "test_breakin known failure with "subprocess wasn't terminated, it
> had to be killed"" https://bugs.launchpad.net/bzr/+bug/408814 Bug
> #545185 in Bazaar: "Last character of path stripped in result
> message" https://bugs.launchpad.net/bzr/+bug/545185 Bug #644221 in
> Bazaar: "bzr help bugs references an old now stale url for squid
> bugzilla" https://bugs.launchpad.net/bzr/+bug/644221 Bug #804553 in
> Bazaar: ""version doesn't match" warning doesn't indicate bzr
> location" https://bugs.launchpad.net/bzr/+bug/804553
>
> For more details, see:
> https://code.launchpad.net/~mbp/bzr/trivial/+merge/72659
>
> If the Python interpreter is compiled (not run) on a Linux 3.0
> kernel, it reports sys.platform == linux3.
>
> Apparently this is patched-around in Ubuntu (or maybe not, looking
> at the changelog.) At any rate saying .startswith('linux') should
> do for the next while.

 merge: approve

I've been following through the threads. In theory, you don't need to
backport a fix. Because only people who are upgrading to a 3.0 kernel
are going to run into it.

python upstream still hasn't settled on whether they want to preserve
"linux2" because there isn't a significant update, or whether they
want to keep the documented "platform+major version" and break lots of
existing code.

I think the recommended fix is to actually use "import platform; ...?"

Anyway, I'm fine with this for now.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk5UylQACgkQJdeBCYSNAANUaACdE095SsHMZNH5+PGG69TH/HgZ
aIYAoKDGV0n9RWZEtzS0hXG0KqcsNc+U
=eOBq
-----END PGP SIGNATURE-----