Code review comment for lp:~mbp/bzr/progress

Revision history for this message
Martin Pool (mbp) wrote :

On 11 July 2010 11:10, John A Meinel <email address hidden> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Martin Pool wrote:
>> thanks for submitting it, I'll look into those failures
>>
>
> Yeah, I was trying to get it into 2.2b4, since it is sort of an api
> change (at least a visual one to the user). It is probably ok to land
> between 2.2b4 and 2.2rc1, but I had hoped to not have to think about
> that. :)

I think fairly small cosmetic ui changes are ok, certainly before the
2.2.0 release.

> Speaking of which MergeIntoMerger... should that be pushed back to 2.3?

From my memory of the type of changes, it seems like it may break some
plugins. Perhaps if we test the likely suspects and find that it
doesn't...

--
Martin

« Back to merge proposal