Code review comment for lp:~mbp/bzr/doc

Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 8/4/2011 2:34 AM, Martin Pool wrote:
> Martin Pool has proposed merging lp:~mbp/bzr/doc into lp:bzr.
>
> Requested reviews: bzr-core (bzr-core) Related bugs: Bug #398653 in
> Bazaar: "Releasing guide should include instructions on updating
> trunk NEWS file" https://bugs.launchpad.net/bzr/+bug/398653 Bug
> #473099 in Bazaar: "Incorrect markup in centralized workflow
> tutorial" https://bugs.launchpad.net/bzr/+bug/473099 Bug #512385 in
> Bazaar: "Broken link to "quick start card" in online user guide"
> https://bugs.launchpad.net/bzr/+bug/512385 Bug #599187 in Bazaar:
> "selective commit not failing as documented"
> https://bugs.launchpad.net/bzr/+bug/599187 Bug #664898 in Bazaar:
> "latex release notes fails with unicode error"
> https://bugs.launchpad.net/bzr/+bug/664898 Bug #746237 in Bazaar:
> "Documentation markup bugs"
> https://bugs.launchpad.net/bzr/+bug/746237
>
> For more details, see:
> https://code.launchpad.net/~mbp/bzr/doc/+merge/70386
>
> abentley pointed out that the simulated-slow-network instructions no
> longer work. (I think the kernel interface must have changed because
> I'm pretty sure they worked a couple of years ago.) These now do.
>
> Another test that these actually pass would be welcome.

I agree that adding something would be nice. But needing root access to
test it seems risky. Not to mention having it accidentally set the
system to add 500ms delay on the loopback could be really terrible for pqm.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk477UsACgkQJdeBCYSNAAMCVQCeLAjcaaOWqRgamQOB2Js5BqW3
BN0AnA0S2kezgibqhkOm4ny7ondLjwkU
=bNpJ
-----END PGP SIGNATURE-----

« Back to merge proposal