Code review comment for lp:~mbp/bzr/446033-readdir

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Pool wrote:
> Martin Pool has proposed merging lp:~mbp/bzr/446033-readdir into lp:bzr/2.0.
>
> Requested reviews:
> bzr-core (bzr-core)
> Related bugs:
> #446033 NoneType has no attribute st_mode in _readdir_pyx.UTF8DirReader.read_dir
> https://bugs.launchpad.net/bugs/446033
>
>
> I don't think there's any point in readdir returning the names of files that no longer exist.
>

I'm fine with this patch, have you tried to do any sort of interactive
testing. Say adding a breakpoint between the readdir and the stat so
that we make sure this is doing what we think it is?

  review: approve
  merge: approve

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkrN7SsACgkQJdeBCYSNAAO9+gCgqalC/ns4LdsknJ5KC9JmsOtl
9hoAn0qZ+8L40DYg1Y6/kTAnHF0QotnW
=S2YB
-----END PGP SIGNATURE-----