Merge lp:~mbp/bzr/408199-check-2a into lp:~bzr/bzr/trunk-old

Proposed by Martin Pool
Status: Merged
Merged at revision: not available
Proposed branch: lp:~mbp/bzr/408199-check-2a
Merge into: lp:~bzr/bzr/trunk-old
Diff against target: 49 lines
To merge this branch: bzr merge lp:~mbp/bzr/408199-check-2a
Reviewer Review Type Date Requested Status
Robert Collins (community) Approve
Review via email: mp+9568@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Martin Pool (mbp) wrote :

Fairly straightforward fix: the blackbox tests should cope with the root id possibly being displayed in the count of file ids.

Revision history for this message
Robert Collins (lifeless) wrote :

 review +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'NEWS'
--- NEWS 2009-08-03 04:47:16 +0000
+++ NEWS 2009-08-03 07:35:22 +0000
@@ -160,6 +160,12 @@
160* --subunit support now adds timestamps if the subunit version supports160* --subunit support now adds timestamps if the subunit version supports
161 it. (Robert Collins)161 it. (Robert Collins)
162162
163Testing
164*******
165
166* Spurious failure in ``check`` tests on rich-root formats fixed.
167 (Martin Pool, #408199)
168
163* The ``bzrlib.tests.TextTestRunner`` will no longer call169* The ``bzrlib.tests.TextTestRunner`` will no longer call
164 ``countTestsCases`` on the test being run. Progress information is170 ``countTestsCases`` on the test being run. Progress information is
165 instead handled by having the test passed in call ``result.progress``171 instead handled by having the test passed in call ``result.progress``
166172
=== modified file 'bzrlib/tests/blackbox/test_check.py'
--- bzrlib/tests/blackbox/test_check.py 2009-03-23 14:59:43 +0000
+++ bzrlib/tests/blackbox/test_check.py 2009-08-03 07:35:22 +0000
@@ -1,4 +1,4 @@
1# Copyright (C) 2007 Canonical Ltd1# Copyright (C) 2007, 2009 Canonical Ltd
2#2#
3# This program is free software; you can redistribute it and/or modify3# This program is free software; you can redistribute it and/or modify
4# it under the terms of the GNU General Public License as published by4# it under the terms of the GNU General Public License as published by
@@ -34,11 +34,12 @@
34 tree = self.make_branch_and_tree('.')34 tree = self.make_branch_and_tree('.')
35 tree.commit('hallelujah')35 tree.commit('hallelujah')
36 out, err = self.run_bzr('check')36 out, err = self.run_bzr('check')
37 # the root directory may be in the texts for rich root formats
37 self.assertContainsRe(err, r"^Checking working tree at '.*'\.\n"38 self.assertContainsRe(err, r"^Checking working tree at '.*'\.\n"
38 r"Checking repository at '.*'\.\n"39 r"Checking repository at '.*'\.\n"
39 r"checked repository.*\n"40 r"checked repository.*\n"
40 r" 1 revisions\n"41 r" 1 revisions\n"
41 r" 0 file-ids\n"42 r" [01] file-ids\n"
42 r" 0 unique file texts\n"43 r" 0 unique file texts\n"
43 r" 0 repeated file texts\n"44 r" 0 repeated file texts\n"
44 r" 0 unreferenced text versions\n"45 r" 0 unreferenced text versions\n"
@@ -59,7 +60,7 @@
59 self.assertContainsRe(err, r"^Checking repository at '.*'\.\n"60 self.assertContainsRe(err, r"^Checking repository at '.*'\.\n"
60 r"checked repository.*\n"61 r"checked repository.*\n"
61 r" 1 revisions\n"62 r" 1 revisions\n"
62 r" 0 file-ids\n"63 r" [01] file-ids\n"
63 r" 0 unique file texts\n"64 r" 0 unique file texts\n"
64 r" 0 repeated file texts\n"65 r" 0 repeated file texts\n"
65 r" 0 unreferenced text versions$")66 r" 0 unreferenced text versions$")