Matt,
First of all thanks to ask me for this review (first one).
Basicaly, you've fixed the config folder's creation bug and the translation bug.
@Josh I can confirm you that dev branches are still translated locally.
But the icon bug is not fixed because I've forgot the folder /apps/ on your icon tree.
You have :
... icons/hicolor/16x16/entertainer.png
and it should be
...icons/hicolor/16x16/apps/entertainer.png
same for 24x24, 48x48 ...
I'll definitly vote Approve after that small change.
Thanks a lot Matt.
Samuel,
« Back to merge proposal
Matt,
First of all thanks to ask me for this review (first one).
Basicaly, you've fixed the config folder's creation bug and the translation bug.
@Josh I can confirm you that dev branches are still translated locally.
But the icon bug is not fixed because I've forgot the folder /apps/ on your icon tree.
You have :
... icons/hicolor/ 16x16/entertain er.png
and it should be
...icons/ hicolor/ 16x16/apps/ entertainer. png
same for 24x24, 48x48 ...
I'll definitly vote Approve after that small change.
Thanks a lot Matt.
Samuel,