Code review comment for lp:~mblayman/entertainer/cfg_to_conf

Revision history for this message
Samuel Buffet (samuel-buffet) wrote :

Matt,

make test : ok
make lint : ok
functional tests : ok

Good work : Approved

the diff:

=== modified file 'entertainerlib/utils/content_management_dialog.py'
--- entertainerlib/utils/content_management_dialog.py 2009-02-10 00:11:06 +0000
+++ entertainerlib/utils/content_management_dialog.py 2009-02-28 18:00:06 +0000
@@ -130,7 +130,7 @@
         try:
             proxy = MessageBusProxy(client_name = "Content Management GUI")
             proxy.connectToMessageBus()
- proxy.sendMessage(Message(MessageType.CONTENT_CFG_UPDATED))
+ proxy.sendMessage(Message(MessageType.CONTENT_CONF_UPDATED))
             proxy.disconnectFromMessageBus()
         except socket.error:
             error = gtk.MessageDialog(
@@ -156,7 +156,7 @@
         try:
             proxy = MessageBusProxy(client_name = "Content Management GUI")
             proxy.connectToMessageBus()
- proxy.sendMessage(Message(MessageType.CONTENT_CFG_UPDATED))
+ proxy.sendMessage(Message(MessageType.CONTENT_CONF_UPDATED))
             proxy.disconnectFromMessageBus()
         except socket.error:
             error = gtk.MessageDialog(

=== modified file 'entertainerlib/utils/preferences_dialog.py'
--- entertainerlib/utils/preferences_dialog.py 2009-02-10 00:25:53 +0000
+++ entertainerlib/utils/preferences_dialog.py 2009-02-28 18:00:06 +0000
@@ -209,7 +209,7 @@
         try:
             proxy = MessageBusProxy(client_name = "Preferences GUI")
             proxy.connectToMessageBus()
- proxy.sendMessage(Message(MessageType.PREFERENCES_CFG_UPDATED))
+ proxy.sendMessage(Message(MessageType.PREFERENCES_CONF_UPDATED))
             proxy.disconnectFromMessageBus()
         except socket.error:
             error = gtk.MessageDialog(

=== modified file 'tools/messagebus-notifier'
--- tools/messagebus-notifier 2009-01-05 05:20:40 +0000
+++ tools/messagebus-notifier 2009-02-28 18:00:06 +0000
@@ -35,8 +35,8 @@
 'MESSAGE_TYPE' should be replaced one of the followings:
     - UPDATE_FEEDS
     - FEED_DB_UPDATED
- - CONTENT_CFG_UPDATED
- - PREFERENCES_CFG_UPDATED
+ - CONTENT_CONF_UPDATED
+ - PREFERENCES_CONF_UPDATED
     - REBUILD_IMAGE_CACHE
     - REBUILD_MUSIC_CACHE
     - REBUILD_VIDEO_CACHE

review: Approve

« Back to merge proposal