Code review comment for lp:~mblayman/entertainer/241727-no-music

Revision history for this message
Joshua Scotton (joshuascotton) wrote :

Entertainer runs ok and the screens displays the correct message as expected

However the "Artist", "Albums" and "Playlists" labels are all red now.

This is due to:
+ self.tab_group = TabGroup(0.95, 0.13, self.theme.getColor("title"))
The color parameter in the TabGroup constructor is NOT a color name. It is the theme descriptor name which is then passed on to the Label object which finally calls self.set_color(self.theme.getColor(color_name)) on line 28 of label.py
Hence line 60 in music_screen.py should be:
            self.tab_group = TabGroup(0.95, 0.13, "title")

Please fix

Tests and pylint work ok. No other problems

review: Disapprove

« Back to merge proposal