Code review comment for ~mb-methot/cloud-init:bug/1699282
Revision history for this message
| Joshua Powers (powersj) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
Hi Marc
Based on a quick look, it appears that in Python3 six.StringIO exists, but not in Python2. As you have corrected, io.BytesIO exists in both. Also CI looks good.
Can I get you to do the following:
1. Set a commit message with a few details:
Summary
<blank line>
More information
...
<blank line>
LP: #1699282
This will link the bug as well.
2. If you have not already, sign the contributor agreement as described in HACKING.rst.
When Scott, Ryan, or Chad are around they can give it a look as well.