Ubuntu

Merge lp:~maxolasersquad/ubuntu/precise/smplayer/add_quicklist into lp:ubuntu/precise/smplayer

Proposed by David Baucum on 2012-02-24
Status: Merged
Merged at revision: 21
Proposed branch: lp:~maxolasersquad/ubuntu/precise/smplayer/add_quicklist
Merge into: lp:ubuntu/precise/smplayer
Diff against target: 19 lines (+12/-0) 1 file modified
To merge this branch: bzr merge lp:~maxolasersquad/ubuntu/precise/smplayer/add_quicklist
Reviewer Review Type Date Requested Status
Daniel Holbach Approve on 2012-02-24
Ubuntu branches 2012-02-24 Pending
Review via email: mp+94500@code.launchpad.net

Description of the Change

Adds Unity Quicklist support.

To post a comment you must log in.
Daniel Holbach (dholbach) wrote :

Good work! I took the liberty to
 - add a changelog entry in your name
 - move the .desktop file change into something the patch system of the package can deal with

http://developer.ubuntu.com/packaging/html/udd-patchsys.html#edit-patch is something which might interest you in this regard. This is the end result: http://paste.ubuntu.com/855106/

Thanks for your work on this.

I'd appreciate if you could forward the change to Upstream or to Debian. https://wiki.ubuntu.com/Debian/Bugs#Using_submittodebian_to_forward_patches_to_Debian has more information on how to do this.

review: Approve
Daniel Holbach (dholbach) wrote :

This was uploaded, but will be sitting in the review queue of the archive admins because we're in Beta Freeze.

Preview Diff

1=== modified file 'smplayer.desktop'
2--- smplayer.desktop 2012-02-16 11:51:44 +0000
3+++ smplayer.desktop 2012-02-24 05:30:22 +0000
4@@ -24,3 +24,15 @@
5 Name=SMPlayer
6 Type=Application
7 X-KDE-StartupNotify=false
8+
9+X-Ayatana-Desktop-Shortcuts=Screen;Window
10+
11+[Mini Shortcut Group]
12+Name=Open with mini GUI
13+Exec=smplayer -minigui
14+TargetEnvironment=Unity
15+
16+[mpc Shortcut Group]
17+Name=Open with mpc GUI
18+Exec=smplayer -mpcgui
19+TargetEnvironment=Unity

Subscribers

People subscribed via source and target branches

to all changes: