Code review comment for lp:~maxolasersquad/ubuntu/precise/smplayer/add_quicklist

Daniel Holbach (dholbach) wrote :

Good work! I took the liberty to
 - add a changelog entry in your name
 - move the .desktop file change into something the patch system of the package can deal with

http://developer.ubuntu.com/packaging/html/udd-patchsys.html#edit-patch is something which might interest you in this regard. This is the end result: http://paste.ubuntu.com/855106/

Thanks for your work on this.

I'd appreciate if you could forward the change to Upstream or to Debian. https://wiki.ubuntu.com/Debian/Bugs#Using_submittodebian_to_forward_patches_to_Debian has more information on how to do this.

review: Approve

« Back to merge proposal