Merge ~maxiberta/ols-jenkaas:job-builder-setup-updates into ols-jenkaas:main

Proposed by Maximiliano Bertacchini
Status: Merged
Approved by: Maximiliano Bertacchini
Approved revision: a99a8579eec6823e390463aae01ff7214a957183
Merged at revision: a99a8579eec6823e390463aae01ff7214a957183
Proposed branch: ~maxiberta/ols-jenkaas:job-builder-setup-updates
Merge into: ols-jenkaas:main
Diff against target: 67 lines (+6/-8)
3 files modified
README.rst (+3/-3)
ols-vms.conf (+1/-1)
setup/job-builder (+2/-4)
Reviewer Review Type Date Requested Status
Guillermo Gonzalez Approve
Review via email: mp+459195@code.launchpad.net

Commit message

Assorted fixes related to the builder container setup

To post a comment you must log in.
Revision history for this message
Maximiliano Bertacchini (maxiberta) :
Revision history for this message
Guillermo Gonzalez (verterok) wrote :

Thanks! looks good, one question (see inline)

review: Needs Information
Revision history for this message
Guillermo Gonzalez (verterok) :
Revision history for this message
Guillermo Gonzalez (verterok) :
review: Approve
Revision history for this message
Guillermo Gonzalez (verterok) wrote :

thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/README.rst b/README.rst
index ec1e762..224a237 100644
--- a/README.rst
+++ b/README.rst
@@ -30,7 +30,7 @@ Production
30==========30==========
3131
32ols-jenkaas is deployed in production at:32ols-jenkaas is deployed in production at:
33https://jenkins.ols.canonical.com/online-services/33https://jenkins.ols.ps5.canonical.com/
3434
35The internal access (requires VPN) to create/update jobs is at:35The internal access (requires VPN) to create/update jobs is at:
36http://online-services-jenkins-be.internal:8080/online-services/36http://online-services-jenkins-be.internal:8080/online-services/
@@ -97,7 +97,7 @@ Setting up ``ols-job-builder`` requires the credentials for
9797
98Authenticating is a bit of a challenge, as ols-jb-bot can't get past98Authenticating is a bit of a challenge, as ols-jb-bot can't get past
99apache-openid. First, log into login.ubuntu.com as yourself, then visit99apache-openid. First, log into login.ubuntu.com as yourself, then visit
100https://jenkins.ols.canonical.com/ to get a cookie for apache-openid. Once100https://jenkins.ols.ps5.canonical.com/ to get a cookie for apache-openid. Once
101there, log out of login.ubuntu.com, grab ols-jb-bot's credentials from enigma,101there, log out of login.ubuntu.com, grab ols-jb-bot's credentials from enigma,
102then hit Jenkins' "log in" button to log in as ols-jb-bot. From there, you can102then hit Jenkins' "log in" button to log in as ols-jb-bot. From there, you can
103go to the configure page for this user, reveal and copy the API token and103go to the configure page for this user, reveal and copy the API token and
@@ -113,7 +113,7 @@ You're now ready to create your job builder::
113You're good to go, edit job descriptions under 'jobs/', raise an MP and get it 113You're good to go, edit job descriptions under 'jobs/', raise an MP and get it
114merged. Then log into the new `ols-job-builder` container and do::114merged. Then log into the new `ols-job-builder` container and do::
115115
116 $ ubuntu@ols-job-builder:~/jenkaas$ bzr pull116 $ ubuntu@ols-job-builder:~/jenkaas$ git pull
117 $ ubuntu@ols-job-builder:~/jenkaas$ jenkins-jobs update --delete-old jobs/117 $ ubuntu@ols-job-builder:~/jenkaas$ jenkins-jobs update --delete-old jobs/
118118
119Note: This a WIP and only applies to members of119Note: This a WIP and only applies to members of
diff --git a/ols-vms.conf b/ols-vms.conf
index 07e88db..c90c607 100644
--- a/ols-vms.conf
+++ b/ols-vms.conf
@@ -70,7 +70,7 @@ apt.sources = ppa:ubuntuone/ols-tests
70# python3-jenkins-job-builder still doesn't work properly70# python3-jenkins-job-builder still doesn't work properly
71# https://bugs.launchpad.net/python-jenkins/+bug/1501441 is blocking the71# https://bugs.launchpad.net/python-jenkins/+bug/1501441 is blocking the
72# migration to zesty72# migration to zesty
73vm.packages = bzr, python3-jenkins-job-builder, python3-pip, python3-setuptools, python3-ols-tests, python3-ols-config73vm.packages = bzr, python3-jenkins-job-builder, python3-pip, python3-setuptools, python3-ols-tests, python3-ols-config, python3-wheel
74vm.setup_scripts = setup/job-builder74vm.setup_scripts = setup/job-builder
7575
76#76#
diff --git a/setup/job-builder b/setup/job-builder
index 16da9c4..905555b 100755
--- a/setup/job-builder
+++ b/setup/job-builder
@@ -5,7 +5,7 @@
55
6# We need to run jenkins_jobs from pip to get the bzr scm :-/6# We need to run jenkins_jobs from pip to get the bzr scm :-/
7LC_ALL=C pip3 install --user jenkins-job-builder==2.10.17LC_ALL=C pip3 install --user jenkins-job-builder==2.10.1
8LC_ALL=C pip3 install --user git+https://github.com/jovandeginste/jenkins-jobs-mattermost.git8LC_ALL=C pip3 install --user git+https://github.com/verterok/jenkins-jobs-mattermost.git
99
10CONF_DIR=~/.config/jenkins_jobs10CONF_DIR=~/.config/jenkins_jobs
11mkdir -p $CONF_DIR11mkdir -p $CONF_DIR
@@ -51,9 +51,7 @@ EOCSE
5151
52# The jenkaas branch itself. For testing, the branch has been pushed from52# The jenkaas branch itself. For testing, the branch has been pushed from
53# the host, for production we pull from the public branch.53# the host, for production we pull from the public branch.
54if [ ! -d jenkaas ] ; then54echo "NOTE: now please get a copy/clone of {{jenkaas}.jobs} under ~/jenkaas"
55 git clone {{jenkaas}.jobs} jenkaas
56fi
5755
58# Inject context from the host56# Inject context from the host
5957

Subscribers

People subscribed via source and target branches