Merge ~maxiberta/ols-jenkaas:job-builder-setup-updates into ols-jenkaas:main

Proposed by Maximiliano Bertacchini
Status: Merged
Approved by: Maximiliano Bertacchini
Approved revision: a99a8579eec6823e390463aae01ff7214a957183
Merged at revision: a99a8579eec6823e390463aae01ff7214a957183
Proposed branch: ~maxiberta/ols-jenkaas:job-builder-setup-updates
Merge into: ols-jenkaas:main
Diff against target: 67 lines (+6/-8)
3 files modified
README.rst (+3/-3)
ols-vms.conf (+1/-1)
setup/job-builder (+2/-4)
Reviewer Review Type Date Requested Status
Guillermo Gonzalez Approve
Review via email: mp+459195@code.launchpad.net

Commit message

Assorted fixes related to the builder container setup

To post a comment you must log in.
Revision history for this message
Maximiliano Bertacchini (maxiberta) :
Revision history for this message
Guillermo Gonzalez (verterok) wrote :

Thanks! looks good, one question (see inline)

review: Needs Information
Revision history for this message
Guillermo Gonzalez (verterok) :
Revision history for this message
Guillermo Gonzalez (verterok) :
review: Approve
Revision history for this message
Guillermo Gonzalez (verterok) wrote :

thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/README.rst b/README.rst
2index ec1e762..224a237 100644
3--- a/README.rst
4+++ b/README.rst
5@@ -30,7 +30,7 @@ Production
6 ==========
7
8 ols-jenkaas is deployed in production at:
9-https://jenkins.ols.canonical.com/online-services/
10+https://jenkins.ols.ps5.canonical.com/
11
12 The internal access (requires VPN) to create/update jobs is at:
13 http://online-services-jenkins-be.internal:8080/online-services/
14@@ -97,7 +97,7 @@ Setting up ``ols-job-builder`` requires the credentials for
15
16 Authenticating is a bit of a challenge, as ols-jb-bot can't get past
17 apache-openid. First, log into login.ubuntu.com as yourself, then visit
18-https://jenkins.ols.canonical.com/ to get a cookie for apache-openid. Once
19+https://jenkins.ols.ps5.canonical.com/ to get a cookie for apache-openid. Once
20 there, log out of login.ubuntu.com, grab ols-jb-bot's credentials from enigma,
21 then hit Jenkins' "log in" button to log in as ols-jb-bot. From there, you can
22 go to the configure page for this user, reveal and copy the API token and
23@@ -113,7 +113,7 @@ You're now ready to create your job builder::
24 You're good to go, edit job descriptions under 'jobs/', raise an MP and get it
25 merged. Then log into the new `ols-job-builder` container and do::
26
27- $ ubuntu@ols-job-builder:~/jenkaas$ bzr pull
28+ $ ubuntu@ols-job-builder:~/jenkaas$ git pull
29 $ ubuntu@ols-job-builder:~/jenkaas$ jenkins-jobs update --delete-old jobs/
30
31 Note: This a WIP and only applies to members of
32diff --git a/ols-vms.conf b/ols-vms.conf
33index 07e88db..c90c607 100644
34--- a/ols-vms.conf
35+++ b/ols-vms.conf
36@@ -70,7 +70,7 @@ apt.sources = ppa:ubuntuone/ols-tests
37 # python3-jenkins-job-builder still doesn't work properly
38 # https://bugs.launchpad.net/python-jenkins/+bug/1501441 is blocking the
39 # migration to zesty
40-vm.packages = bzr, python3-jenkins-job-builder, python3-pip, python3-setuptools, python3-ols-tests, python3-ols-config
41+vm.packages = bzr, python3-jenkins-job-builder, python3-pip, python3-setuptools, python3-ols-tests, python3-ols-config, python3-wheel
42 vm.setup_scripts = setup/job-builder
43
44 #
45diff --git a/setup/job-builder b/setup/job-builder
46index 16da9c4..905555b 100755
47--- a/setup/job-builder
48+++ b/setup/job-builder
49@@ -5,7 +5,7 @@
50
51 # We need to run jenkins_jobs from pip to get the bzr scm :-/
52 LC_ALL=C pip3 install --user jenkins-job-builder==2.10.1
53-LC_ALL=C pip3 install --user git+https://github.com/jovandeginste/jenkins-jobs-mattermost.git
54+LC_ALL=C pip3 install --user git+https://github.com/verterok/jenkins-jobs-mattermost.git
55
56 CONF_DIR=~/.config/jenkins_jobs
57 mkdir -p $CONF_DIR
58@@ -51,9 +51,7 @@ EOCSE
59
60 # The jenkaas branch itself. For testing, the branch has been pushed from
61 # the host, for production we pull from the public branch.
62-if [ ! -d jenkaas ] ; then
63- git clone {{jenkaas}.jobs} jenkaas
64-fi
65+echo "NOTE: now please get a copy/clone of {{jenkaas}.jobs} under ~/jenkaas"
66
67 # Inject context from the host
68

Subscribers

People subscribed via source and target branches