Merge lp:~maxiberta/mojo/ignore-app-wait-support into lp:~verterok/mojo/ignore-app-wait-support

[Maximiliano Bertacchini]

Fix mutable default args related to ignore-applications-wait

=== modified file 'mojo/juju/status.py'
--- mojo/juju/status.py	2024-03-13 18:40:32 +0000
+++ mojo/juju/status.py	2024-03-15 16:22:35 +0000
@@ -457,11 +457,11 @@
 
         return list(units.keys())
 
-    def applications_ready(self, ignore_applications=[]):
+    def applications_ready(self, ignore_applications=None):
         """Check status of all applications, raise JujuStatusError for an error state.
         Returns: True if the applications in the status are in a good state, False if they are busy.
         """
-        applications = self.yaml_status(ignore_applications=ignore_applications)["applications"]
+        applications = self.yaml_status(ignore_applications=ignore_applications or [])["applications"]
 
         for name in applications:
             application = applications[name]
@@ -542,11 +542,11 @@
             return None
         return machine.get("instance-id")
 
-    def machines_ready(self, ignore_applications=[]):
+    def machines_ready(self, ignore_applications=None):
         """Check status of all machines, raise JujuStatusError for an error state.
         Returns: True if the machines in the status are in a good state, False if they are busy.
         """
-        machines = self.yaml_status(ignore_applications=ignore_applications)["machines"]
+        machines = self.yaml_status(ignore_applications=ignore_applications or [])["machines"]
 
         for num in machines:
             machine = machines[num]
@@ -602,11 +602,11 @@
             self._cached_status = None
         return self._raw_status
 
-    def subordinates_ready(self, ignore_applications=[]):
+    def subordinates_ready(self, ignore_applications=None):
         """Check status of all subordinate units, raise JujuStatusError for an error state.
         Returns: True if the subordinate in the status are in a good state, False if they are busy.
         """
-        applications = self.yaml_status(ignore_applications=ignore_applications)["applications"]
+        applications = self.yaml_status(ignore_applications=ignore_applications or [])["applications"]
 
         for app in applications:
             units = self._get_units(app)
@@ -620,7 +620,7 @@
 
             for name in subordinates:
                 # skip ignored applications
-                if name.split('/')[0] in ignore_applications:
+                if name.split('/')[0] in (ignore_applications or []):
                     continue
                 subordinate = subordinates[name]
 
@@ -637,11 +637,11 @@
 
         return True
 
-    def units_ready(self, ignore_applications=[]):
+    def units_ready(self, ignore_applications=None):
         """Check status of all units, raise JujuStatusError for an error state.
         Returns: True if the units in the status are in a good state, False if they are busy.
         """
-        applications = self.yaml_status(ignore_applications=ignore_applications)["applications"]
+        applications = self.yaml_status(ignore_applications=ignore_applications or [])["applications"]
 
         for app in applications:
             units = self._get_units(app)
@@ -658,7 +658,7 @@
 
         return True
 
-    def yaml_status(self, force_update=False, ignore_applications=[]):
+    def yaml_status(self, force_update=False, ignore_applications=None):
         """
         Args:
             force_update: If true update from Juju.
@@ -667,7 +667,7 @@
         if not self._cached_status or force_update:
             self._cached_status = yaml.safe_load(self.status(force_update))
         # remove snapstore-admin application
-        for to_ignore in ignore_applications:
+        for to_ignore in (ignore_applications or []):
             removed = self._cached_status["applications"].pop(to_ignore, None)
             if removed:
                 if "subordinate-to" in removed:

=== modified file 'mojo/juju/wait.py'
--- mojo/juju/wait.py	2024-03-13 18:40:32 +0000
+++ mojo/juju/wait.py	2024-03-15 16:22:35 +0000
@@ -258,6 +258,8 @@
     # worth of setup hooks to run before it is complete. wait_for_workload
     # does allow you to ignore infinite hook loops and other similar bugs
     # in your charms.
+    ignore_applications = ignore_applications or []
+
     if log is None:
         log = logging.getLogger()