Code review comment for lp:~maxiberta/canonical-identity-provider/openid-session-limit

Revision history for this message
Daniel Manrique (roadmr) wrote :

+1 from me code-wise, I made some observations re: a comment and a test.

About multiple session/device/browser - I was thinking this is probably not an issue, because each different browser/device will get an entirely new Django session; we discussed an example with 5 devices and calculated 2 openid "sessions" per device, but in reality each device would have its own django "session" containing up to 10 openid "sessions" which does seem a bit excessive. Still, the value of 10 is a good starting point and we could tweak using the Juju setting.

review: Approve

« Back to merge proposal