Merge lp:~maxiberta/canonical-identity-provider/drop-unused-terms into lp:canonical-identity-provider/release

[Maximiliano Bertacchini]

Drop unused terms views.

Awaiting confirmation that the dropped view is not in use: https://portal.admin.canonical.com/C124295/

UPDATE: got sso prod logs for the last ~6 months (starting on 2019-06-27). Only 6 hits to /terms/embedded/, 4 of which was probably me (Firefox 74 on linux), and 2 have a "mail.ru Bot" UA. So, I believe it is safe to drop this endpoint.

https://pastebin.canonical.com/p/Q7zHjzhj7P/

[Daniel Manrique (roadmr)]

bye bye terms

review: Approve

=== removed directory 'src/webui/templates/static/terms'
=== removed file 'src/webui/templates/static/terms.html'
=== removed file 'src/webui/templates/static/terms/_terms_nav.html'
=== removed file 'src/webui/templates/static/terms/_terms_text.html'
=== removed file 'src/webui/templates/static/terms_embedded.html'
=== modified file 'src/webui/urls.py'
--- src/webui/urls.py	2018-08-24 15:31:13 +0000
+++ src/webui/urls.py	2020-02-19 14:35:56 +0000
@@ -130,12 +130,6 @@
         name='one-redirect'),
     url(r'^terms/$', RedirectView.as_view(url=settings.TERMS_OF_SERVICE_URL),
         name='terms_and_conditions'),
-    # XXX cjwatson 2018-05-23: Is this still used?  If so, we need an
-    # embedded-themed version of this page on the legal site that we can
-    # redirect to.
-    url(r'^terms/embedded/$', static_page,
-        {'page_name': 'terms_embedded.html'},
-        name='terms_and_conditions_embedded'),
     url(r'^privacy/$', RedirectView.as_view(url=settings.PRIVACY_POLICY_URL),
         name='privacy_policy'),
     url(r'^privacy-notice/$',