Code review comment for lp:~maxiberta/canonical-identity-provider/canonical-email-urls

Generally agree with the change to respect the settings parameter, instead of calculate it from the context request.

I wish the change was smaller by avoiding changing the implementation and methods signatures at the same time, but you already managed to do it all at once <bonus/>.