Code review comment for ~maxiberta/canonical-identity-provider:preflight-table-css

Revision history for this message
Daniel Manrique (roadmr) wrote :

+1, next time I would suggest putting the generated CSS in a separate commit; it took me a while to find the source change (one line ;):

diff --git a/src/identityprovider/static_src/scss/styles.scss b/src/identityprovider/static_src/scss/styles.scss
index 93396c9..da9a954 100644
--- a/src/identityprovider/static_src/scss/styles.scss
+++ b/src/identityprovider/static_src/scss/styles.scss
@@ -84,3 +84,7 @@ $breakpoint-navigation-threshold: 1px;
   font-size: 1rem;
 }

+// Prevent overlapped table columns in preflight report
+table#switches-table {
+ table-layout: auto;
+}

review: Approve

« Back to merge proposal