Code review comment for lp:~maxb/udd/environment-setup

Revision history for this message
Max Bowsher (maxb) wrote :

> > You're right, I'll move the distro-info bit.
> >
> > I *do* think this is the way to go, as I feel it's an outright bug that
> Python
> > scripts require external assistance to import modules which are guaranteed
> to
> > be at a given relative path from the scripts themselves.
>
>
> Actually, there are not guaranteed to be there, that's specific to the jubany
> deployment and even there, in the long term, we should rely on packaged
> versions...

I'm referring to the udd.* modules, which are in the same bzr branch as the bin/ directory - that's a pretty hard guarantee where they are - unless you're saying people are deploying udd code not via a bzr branch?

> > Maybe, in some super-complex deployment scenarios, a "py.sh" is the way to
> go.
> > But UDD isn't a super-complex deployment scenario, it's easily in reach for
> > the scripts to just do the right thing, without wrappers.
> >
> > Amongst other things, I want to be able to just tab-complete something in
> bin/
> > and have it work! :-)
>
> Which I achieve by sourcing fixit.sh ;)

But that's a hack, and we shouldn't have to do it.

« Back to merge proposal