Code review comment for lp:~maxb/udd/environment-setup

Revision history for this message
James Westby (james-w) wrote :

10 +# bzr-builddeb requires distro-info
11 +sys.path.insert(0, os.path.join(udd_root, 'distro-info', 'python'))

I think that might only be needed by import-package as well?

I think I'm ok with this landing, as I don't think it would have an adverse
affect on our deployment. However, I don't think that it is the way to go.
I think that the deployment of the scripts should be separated from the code,
so that it can be re-used (as we are, and others may want to.)

Elsewhere we've started adding "py.sh" scripts to the deployment (via puppet
in those cases) that set up the environment for running the scripts. It's
one more thing to put in the command-line, but it allows for any customization
without cluttering the codebase. Maybe we could use that model here.

Thanks,

James

« Back to merge proposal