Code review comment for lp:~maxb/bzr-cvsps-import/fix-test

Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2/19/2011 2:11 AM, Max Bowsher wrote:
> Max Bowsher has proposed merging lp:~maxb/bzr-cvsps-import/fix-test into lp:bzr-cvsps-import.
>
> Requested reviews:
> Bazaar Developers (bzr)
>
> For more details, see:
> https://code.launchpad.net/~maxb/bzr-cvsps-import/fix-test/+merge/50421

Off-hand this feels like the wrong fix. Since '.' is a special module,
it doesn't seem like it should be present in the path that files are
being imported from.

At least, importing foo/./bar seems weird, even if it isn't illegal.

 review: needsinfo

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk1uFHcACgkQJdeBCYSNAAMM0wCg0lzSZVC94myXmQ7Xk2u8YEZ9
QPYAoIkf4AxCUwHFm4eAhuIVXI89wsDe
=Edky
-----END PGP SIGNATURE-----

review: Needs Information

« Back to merge proposal