Merge lp:~maxb/bzr-builddeb/testfix2 into lp:bzr-builddeb

Proposed by Max Bowsher
Status: Merged
Approved by: Jelmer Vernooij
Approved revision: 529
Merged at revision: 530
Proposed branch: lp:~maxb/bzr-builddeb/testfix2
Merge into: lp:bzr-builddeb
Prerequisite: lp:~maxb/bzr-builddeb/python-debian-compat
Diff against target: 34 lines (+4/-4)
1 file modified
tests/test_upstream.py (+4/-4)
To merge this branch: bzr merge lp:~maxb/bzr-builddeb/testfix2
Reviewer Review Type Date Requested Status
Jelmer Vernooij Approve
Review via email: mp+51436@code.launchpad.net

Commit message

Fix some tests which erroneously expect a Version object instead of a string.

To post a comment you must log in.
Revision history for this message
Jelmer Vernooij (jelmer) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'tests/test_upstream.py'
--- tests/test_upstream.py 2011-02-21 16:49:06 +0000
+++ tests/test_upstream.py 2011-02-26 21:12:28 +0000
@@ -375,18 +375,18 @@
375375
376 def test_snapshot_none_existing(self):376 def test_snapshot_none_existing(self):
377 self.revhistory = ["somerevid"]377 self.revhistory = ["somerevid"]
378 self.assertEquals(Version("1.2+bzr1"),378 self.assertEquals("1.2+bzr1",
379 _upstream_branch_version(self.revhistory, {}, "bla", "1.2", self.get_suffix))379 _upstream_branch_version(self.revhistory, {}, "bla", "1.2", self.get_suffix))
380380
381 def test_snapshot_nothing_new(self):381 def test_snapshot_nothing_new(self):
382 self.revhistory = []382 self.revhistory = []
383 self.assertEquals(Version("1.2"),383 self.assertEquals("1.2",
384 _upstream_branch_version(self.revhistory, {}, "bla", "1.2", self.get_suffix))384 _upstream_branch_version(self.revhistory, {}, "bla", "1.2", self.get_suffix))
385385
386 def test_new_tagged_release(self):386 def test_new_tagged_release(self):
387 """Last revision is tagged - use as upstream version."""387 """Last revision is tagged - use as upstream version."""
388 self.revhistory = ["somerevid"]388 self.revhistory = ["somerevid"]
389 self.assertEquals(Version("1.3"),389 self.assertEquals("1.3",
390 _upstream_branch_version(self.revhistory, {"somerevid": [u"1.3"]}, "bla", "1.2", self.get_suffix))390 _upstream_branch_version(self.revhistory, {"somerevid": [u"1.3"]}, "bla", "1.2", self.get_suffix))
391391
392 def test_refresh_snapshot_pre(self):392 def test_refresh_snapshot_pre(self):
@@ -411,7 +411,7 @@
411class TestUpstreamTagToVersion(TestCase):411class TestUpstreamTagToVersion(TestCase):
412412
413 def test_prefix(self):413 def test_prefix(self):
414 self.assertEquals(Version("5.0"), upstream_tag_to_version(u"release-5.0"))414 self.assertEquals("5.0", upstream_tag_to_version(u"release-5.0"))
415415
416 def test_gibberish(self):416 def test_gibberish(self):
417 self.assertIs(None, upstream_tag_to_version(u"blabla"))417 self.assertIs(None, upstream_tag_to_version(u"blabla"))

Subscribers

People subscribed via source and target branches