Code review comment for lp:~max-rabkin/ibid/google-translate

Revision history for this message
Max Rabkin (max-rabkin) wrote :

Using a hard-coded language list means we can tell users which languages we support, and we can use a normal @match to extract the arguments. It also means we use Google's language codes, which are not the same as ISO 639-1: they use "iw" for Hebrew instead of "he" (but accept both), and other functions in the Language API use the ISO 639-2 code for Cherokee (there is no 639-1 code). Also, we can read the languages right there in the code, so no more surprises like Greek.

Of course, there are the usual disadvantages of hard-coded values: basically, when Google adds languages, we'll have to update the list.

« Back to merge proposal