Merge lp:~matzipan/pantheon-mail/migrations-fix into lp:~elementary-apps/pantheon-mail/trunk

Proposed by Zisu Andrei
Status: Merged
Approved by: Danielle Foré
Approved revision: 1979
Merged at revision: 1982
Proposed branch: lp:~matzipan/pantheon-mail/migrations-fix
Merge into: lp:~elementary-apps/pantheon-mail/trunk
Diff against target: 22 lines (+2/-1)
2 files modified
CMakeLists.txt (+0/-1)
data/CMakeLists.txt (+2/-0)
To merge this branch: bzr merge lp:~matzipan/pantheon-mail/migrations-fix
Reviewer Review Type Date Requested Status
Danielle Foré Approve
Review via email: mp+286913@code.launchpad.net

Commit message

Moved sqlite migration files where local build expects them to be

To post a comment you must log in.
Revision history for this message
Danielle Foré (danrabbit) wrote :

Hey thanks for you branch! Please use "bzr mv" to relocate files and folders instead. This makes the diff smaller and easier to verify

review: Needs Fixing
Revision history for this message
Zisu Andrei (matzipan) wrote :

I noticed that. I didn't know bazaar has that functionality. I'm too used to git :(

1979. By Zisu Andrei

Moved sqlite migration files where local build expects them to be

Revision history for this message
Zisu Andrei (matzipan) wrote :

Fixed.

Revision history for this message
Danielle Foré (danrabbit) wrote :

Works for me, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'CMakeLists.txt'
--- CMakeLists.txt 2016-02-17 01:21:06 +0000
+++ CMakeLists.txt 2016-02-23 17:03:47 +0000
@@ -98,6 +98,5 @@
9898
99add_subdirectory(data)99add_subdirectory(data)
100add_subdirectory(po)100add_subdirectory(po)
101add_subdirectory(sql)
102add_subdirectory(src)101add_subdirectory(src)
103102
104103
=== modified file 'data/CMakeLists.txt'
--- data/CMakeLists.txt 2016-02-17 18:59:49 +0000
+++ data/CMakeLists.txt 2016-02-23 17:03:47 +0000
@@ -37,3 +37,5 @@
3737
38add_subdirectory(theming)38add_subdirectory(theming)
39add_subdirectory(ui)39add_subdirectory(ui)
40add_subdirectory(sql)
41
4042
=== renamed directory 'sql' => 'data/sql'

Subscribers

People subscribed via source and target branches