On 2014/02/25 10:15:52, dimitern wrote:
> Looks good, but make sure you're familiar with Martin's recent 1.16
> compatibility for status changes: https://codereview.appspot.com/66590043/
> You'll need to use the FullStatus API call.
Sorry, so your changes are in statecmd, which gets called internally in
apiserver for both FullStatus and Status.
This means you don't need to care about FullStatus in your CL.
Your changes LGTM assuming you've tested them live as well, just in
case.
On 2014/02/25 10:15:52, dimitern wrote: /codereview. appspot. com/66590043/
> Looks good, but make sure you're familiar with Martin's recent 1.16
> compatibility for status changes:
https:/
> You'll need to use the FullStatus API call.
Sorry, so your changes are in statecmd, which gets called internally in
apiserver for both FullStatus and Status.
This means you don't need to care about FullStatus in your CL.
Your changes LGTM assuming you've tested them live as well, just in
case.
https:/ /codereview. appspot. com/67870043/