Code review comment for lp:~mattyw/charms/trusty/mongodb/mongodb-backup

Revision history for this message
Marco Ceppi (marcoceppi) wrote :

I've got a few suggestions.

First, we have action-get, action-set, and action-fail in charmhelpers. I'd consider re-syncing charm-helpers in hooks/charmhelpers to include these updated methods then importing them in the actions files.

Also, symlinking to a .py file is a bit tedious, instead to address the lack of linting coverage, I'd recommend the following patch: http://paste.ubuntu.com/12698613/ which addresses the lack of lint coverage without creating symlinks.

review: Needs Fixing

« Back to merge proposal