Juju Charms Collection
mongodb package

Code review comment for lp:~mattyw/charms/trusty/mongodb/mongodb-backup

  1. Trusty Tahr (14.04)
  2. mongodb-backup
  3. Merge into trunk
Revision history for this message
Ryan Beisner (1chb1n) wrote :

Please adjust the Makefile in your proposal to add lint test coverage of the new actions dir:

- .venv/bin/flake8 --exclude hooks/charmhelpers hooks tests unit_tests

+ .venv/bin/flake8 --exclude hooks/charmhelpers actions hooks tests unit_tests

Also: By default, flake8 will not check files in a directory unless they have a .py extension. Please use the .py extension on the action files.

Thank you

review: Needs Fixing

« Back to merge proposal