Merge lp:~matttbe/chromium-browser/lp1013171 into lp:~chromium-team/chromium-browser/chromium-browser.quantal

Proposed by Matthieu Baerts
Status: Merged
Merged at revision: 745
Proposed branch: lp:~matttbe/chromium-browser/lp1013171
Merge into: lp:~chromium-team/chromium-browser/chromium-browser.quantal
Diff against target: 82 lines (+17/-8)
2 files modified
debian/apport/chromium-browser.py (+9/-8)
debian/changelog (+8/-0)
To merge this branch: bzr merge lp:~matttbe/chromium-browser/lp1013171
Reviewer Review Type Date Requested Status
Ken VanDine Approve
Chromium team Pending
Review via email: mp+113055@code.launchpad.net

Description of the change

Hello members of the Chromium team,

This is just a patch to update apport hook for python3.
I set you as reviewer because you're the owner of the main branch but I can add ubuntu-sponsors team and propose a debdiff if you want ;)

Have a nice day,

Matt

To post a comment you must log in.
Revision history for this message
Ken VanDine (ken-vandine) wrote :

This was merged into my branch

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/apport/chromium-browser.py'
--- debian/apport/chromium-browser.py 2011-05-09 17:41:33 +0000
+++ debian/apport/chromium-browser.py 2012-07-02 14:36:23 +0000
@@ -11,6 +11,7 @@
11the full text of the license.11the full text of the license.
12'''12'''
1313
14from __future__ import print_function
14import os, sys, getopt, codecs15import os, sys, getopt, codecs
15import time16import time
16from stat import *17from stat import *
@@ -57,7 +58,7 @@
57 report['RelatedPackagesPolicy'] = ''58 report['RelatedPackagesPolicy'] = ''
58 for pkg in pkgs:59 for pkg in pkgs:
59 script = subprocess.Popen(['apt-cache', 'policy', pkg], stdout=subprocess.PIPE)60 script = subprocess.Popen(['apt-cache', 'policy', pkg], stdout=subprocess.PIPE)
60 report['RelatedPackagesPolicy'] += script.communicate()[0] + "\n"61 report['RelatedPackagesPolicy'] += str(script.communicate()[0]) + "\n"
6162
62def gconf_values(report, keys):63def gconf_values(report, keys):
63 report['gconf-keys'] = ''64 report['gconf-keys'] = ''
@@ -67,7 +68,7 @@
67 except OSError:68 except OSError:
68 report['gconf-keys'] = "gconftool-2 not found"69 report['gconf-keys'] = "gconftool-2 not found"
69 return70 return
70 out = script.communicate()[0]71 out = str(script.communicate()[0])
71 if out == "":72 if out == "":
72 out = "**unset**\n"73 out = "**unset**\n"
73 report['gconf-keys'] += key + " = " + out74 report['gconf-keys'] += key + " = " + out
@@ -105,7 +106,7 @@
105 # list entensions+versions106 # list entensions+versions
106 report['ChromiumPrefs'] += "extensions/settings =\n"107 report['ChromiumPrefs'] += "extensions/settings =\n"
107 if 'settings' in entry['extensions']:108 if 'settings' in entry['extensions']:
108 for ext in entry['extensions']['settings'].keys():109 for ext in list(entry['extensions']['settings'].keys()):
109 report['ChromiumPrefs'] += " - '" + ext + "'\n"110 report['ChromiumPrefs'] += " - '" + ext + "'\n"
110 if 'manifest' in entry['extensions']['settings'][ext]:111 if 'manifest' in entry['extensions']['settings'][ext]:
111 for k in [ 'name', 'description', 'version', 'update_url' ]:112 for k in [ 'name', 'description', 'version', 'update_url' ]:
@@ -243,17 +244,17 @@
243244
244 # Disk usage245 # Disk usage
245 script = subprocess.Popen([ 'df', '-Th' ], stdout=subprocess.PIPE)246 script = subprocess.Popen([ 'df', '-Th' ], stdout=subprocess.PIPE)
246 report['DiskUsage'] = script.communicate()[0] + "\n\nInodes:\n"247 report['DiskUsage'] = str(script.communicate()[0]) + "\n\nInodes:\n"
247 script = subprocess.Popen([ 'df', '-ih' ], stdout=subprocess.PIPE)248 script = subprocess.Popen([ 'df', '-ih' ], stdout=subprocess.PIPE)
248 report['DiskUsage'] += script.communicate()[0]249 report['DiskUsage'] += str(script.communicate()[0])
249250
250## DEBUGING ##251## DEBUGING ##
251if __name__ == '__main__':252if __name__ == '__main__':
252 sys.stdout = codecs.getwriter('utf8')(sys.stdout)253 sys.stdout = codecs.getwriter('utf8')(sys.stdout)
253 try:254 try:
254 opts, args = getopt.getopt(sys.argv[1:], "-u:", [ 'user-dir=' ])255 opts, args = getopt.getopt(sys.argv[1:], "-u:", [ 'user-dir=' ])
255 except getopt.GetoptError, err:256 except getopt.GetoptError as err:
256 print str(err)257 print(str(err))
257 sys.exit(2)258 sys.exit(2)
258259
259 userdir = None260 userdir = None
@@ -266,4 +267,4 @@
266 report = {}267 report = {}
267 add_info(report, userdir = userdir)268 add_info(report, userdir = userdir)
268 for key in report:269 for key in report:
269 print '[%s]\n%s\n' % (key, report[key])270 print('[%s]\n%s\n' % (key, report[key]))
270271
=== modified file 'debian/changelog'
--- debian/changelog 2012-06-18 16:37:20 +0000
+++ debian/changelog 2012-07-02 14:36:23 +0000
@@ -1,3 +1,11 @@
1chromium-browser (18.0.1025.168~r134367-0ubuntu2) UNRELEASED; urgency=low
2
3 * debian/apport:
4 - Update apport hook for python3 (LP: #1013171)
5 patch made with the help of Edward Donovan
6
7 -- Matthieu Baerts (matttbe) <matttbe@gmail.com> Mon, 02 Jul 2012 16:21:57 +0200
8
1chromium-browser (18.0.1025.168~r134367-0ubuntu1) quantal; urgency=low9chromium-browser (18.0.1025.168~r134367-0ubuntu1) quantal; urgency=low
2 10
3 * debian/rules11 * debian/rules

Subscribers

People subscribed via source and target branches

to all changes: