MAAS

Merge ~mattrae/maas:master into maas:master

  1. Git
  2. lp:~mattrae/maas
  3. master
  4. Merge into master
Proposed by Matt Rae
Status: Merged
Approved by: Blake Rouse
Approved revision: 19da0355bd7532f90505cd13e022ef6e7ff29322
Merge reported by: MAAS Lander
Merged at revision: not available
Proposed branch: ~mattrae/maas:master
Merge into: maas:master
Diff against target: 13 lines (+1/-1)
1 file modified
src/metadataserver/user_data/templates/snippets/maas_wipe.py (+1/-1)
Reviewer Review Type Date Requested Status
Blake Rouse (community) Approve
Review via email: mp+329064@code.launchpad.net

Commit message

LP: #1708052 -- Quick erase doesn't remove md superblock

Increase write to 2 MB to beginning of the disk so software raid superblock are wiped.

Description of the change

LP: #1708052 -- Quick erase doesn't remove md superblock

Increase write to 2 MB to beginning of the disk so software raid superblock are wiped.

To post a comment you must log in.
Revision history for this message
Blake Rouse (blake-rouse) wrote :

Looks good. Thanks for the fix.

review: Approve
Revision history for this message
MAAS Lander (maas-lander) wrote :

LANDING
-b master lp:~mattrae/maas into -b master lp:~maas-committers/maas

STATUS: FAILED BUILD
LOG: http://maas-ci-jenkins.internal:8080/job/maas/job/branch-tester/193/consoleText

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/src/metadataserver/user_data/templates/snippets/maas_wipe.py b/src/metadataserver/user_data/templates/snippets/maas_wipe.py
2index fd63daf..9dfe96e 100644
3--- a/src/metadataserver/user_data/templates/snippets/maas_wipe.py
4+++ b/src/metadataserver/user_data/templates/snippets/maas_wipe.py
5@@ -173,7 +173,7 @@ def wipe_quickly(kname):
6 the device.
7 """
8 print_flush("%s: starting quick wipe." % kname.decode('ascii'))
9- buf = b'\0' * 1024 * 1024 # 1 MiB
10+ buf = b'\0' * 1024 * 1024 * 2 # 2 MiB
11 with open(DEV_PATH % kname, "wb") as fp:
12 fp.write(buf)
13 fp.seek(-len(buf), 2)

Subscribers

People subscribed via source and target branches