Code review comment for lp:~mattknox/libmemcached/twitter-compat

> The code in this branch caches memcached server errors in the
> memcached_server_st struct to give better visibility into failures. I've
> tested it both with its own suite and that of the ruby interface to it, and
> also run it in a development environment. So far it looks fine on all counts.

There are a few problems with this.

1) You don't test for memory failures.
2) Lets say you have a failure, how do you know which server it was that had the error?
3) How do you clean up the error (aka reset the error)?
4) There is no function to encapsulate the error message. Which means any future changes to the structure are going to break if any renaming occurs.

I'll clean this up a bit... but something needs to be figured out so that you know via some vector about which servers got errors in the last run.

I can certainly see the usefulness in this for debugging on production sites.