Code review comment for lp:~matthias-troffaes/pybtex/even-simpler-plugin-loader

Revision history for this message
Matthias C. M. Troffaes (matthias-troffaes) wrote :

Ok, great! License & pep8 fixes are of course no problem.

Concerning the first point, I sort of convinced myself that, eventually, names/aliases/suffixes do not belong to the plugin class, at least not as static class attributes, because we cannot know in advance what kind of aliases or suffixes a user is going to register for a plugin. This is already the case for the entry point plugins in the original code: in fact their name/suffixes/aliases attributes were entirely ignored IIRC. For reasons purely due to causality: with entry point plugins, we need to know the name before we even have the class.

Could you bring yourself to think of name, aliases, and suffixes as belonging to the registry system, rather than belonging to the Plugin classes?

« Back to merge proposal