Code review comment for lp:~matthias-troffaes/pybtex/even-simpler-plugin-loader

Revision history for this message
Andrey Golovizin (ero-sennin) wrote :

This makes sense.

There are some things though.

- I'd want to keep Plugin.name, Plugin.aliases and Plugin.suffixes. The idea is that all information about a plugin should be contained in a plugin itself and not be scattered all over. Also, this way it would be possible to call register_plugin(SomePlugin) without extra arguments, and register_plugin() would care about registering all the necessary entry points for you.

- Please add a license header to plugin_test.py and use two blank lines between top-level definitions. (Just a nitpick.)

« Back to merge proposal