Merge lp:~matthias-cramer/charms/precise/haproxy/appsession into lp:charms/haproxy
Proposed by
Matthias Cramer
Status: | Rejected |
---|---|
Rejected by: | Tom Haddon |
Proposed branch: | lp:~matthias-cramer/charms/precise/haproxy/appsession |
Merge into: | lp:charms/haproxy |
Diff against target: |
81 lines (+30/-2) (has conflicts) 3 files modified
config.yaml (+4/-0) hooks/hooks.py (+22/-2) revision (+4/-0) Text conflict in hooks/hooks.py Text conflict in revision |
To merge this branch: | bzr merge lp:~matthias-cramer/charms/precise/haproxy/appsession |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Tom Haddon | Needs Fixing | ||
charmers | Pending | ||
Review via email: mp+148651@code.launchpad.net |
Description of the change
Added possibility to add appsession parameter to the configfile
To post a comment you must log in.
Unmerged revisions
- 65. By Matthias Cramer
-
added more description
- 64. By Matthias Cramer
-
Added config parameter listen_appsession to set appsession parameter
There seem to be two text conflicts in the merge proposal - can you take a look?
Also, I think this may be achievable within the existing charm just by appending "spip_session len 34 timeout 3h request-learn" to the "service_options" parameter. As an example, if you have this:
services: |
service_ host: "0.0.0.0"
service_ port: 80
service_ options: [option httpchk GET /, balance leastconn]
server_ options: check inter 2000 rise 2 fall 5 maxconn 32
- service_name: haproxy_service
You could simply change it to this:
services: |
service_ host: "0.0.0.0"
service_ port: 80
service_ options: [option httpchk GET /, balance leastconn, spip_session len 34 timeout 3h request-learn]
server_ options: check inter 2000 rise 2 fall 5 maxconn 32
- service_name: haproxy_service
Can you try that and see if it does what you're hoping to achieve?