Code review comment for lp:~matthias-cramer/charms/precise/haproxy/appsession

Revision history for this message
Tom Haddon (mthaddon) wrote :

There seem to be two text conflicts in the merge proposal - can you take a look?

Also, I think this may be achievable within the existing charm just by appending "spip_session len 34 timeout 3h request-learn" to the "service_options" parameter. As an example, if you have this:

    services: |
              - service_name: haproxy_service
                service_host: "0.0.0.0"
                service_port: 80
                service_options: [option httpchk GET /, balance leastconn]
                server_options: check inter 2000 rise 2 fall 5 maxconn 32

You could simply change it to this:

    services: |
              - service_name: haproxy_service
                service_host: "0.0.0.0"
                service_port: 80
                service_options: [option httpchk GET /, balance leastconn, spip_session len 34 timeout 3h request-learn]
                server_options: check inter 2000 rise 2 fall 5 maxconn 32

Can you try that and see if it does what you're hoping to achieve?

review: Needs Fixing

« Back to merge proposal