Code review comment for lp:~matsubara/tarmac/bundle-lander
Revision history for this message
| Diogo Matsubara (matsubara) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
Hi Gary,
based in our conversation on IRC I added tests to the lock file mechanism and to the functions in the pidfile.py module. I removed an XXX in the bundle merge command test to make it more complete.
Let me know what you think and if this is ok to be merged.
Thanks for the detailed review and help.