Merge lp:~matsubara/maas/syslinux-dev-dep-utopic into lp:~maas-maintainers/maas/packaging

Proposed by Diogo Matsubara
Status: Merged
Approved by: Diogo Matsubara
Approved revision: 283
Merged at revision: 283
Proposed branch: lp:~matsubara/maas/syslinux-dev-dep-utopic
Merge into: lp:~maas-maintainers/maas/packaging
Diff against target: 13 lines (+1/-1)
1 file modified
debian/control (+1/-1)
To merge this branch: bzr merge lp:~matsubara/maas/syslinux-dev-dep-utopic
Reviewer Review Type Date Requested Status
Blake Rouse (community) Approve
Review via email: mp+223967@code.launchpad.net

Commit message

Update maas-cluster-controller to use strictly earlier option for Trusty's syslinux-common dependency

Description of the change

Change how syslinux-dev and syslinux-common dependencies for maas-cluster-controller are handled. Previously setting only syslinux-dev | syslinux-common, made the package install only syslinux-common on Utopic. Setting the strictly earlier option, as suggested by Colin seems to do the trick and the package installs correctly both on Utopic and Trusty.

I ran the integration tests with this packaging branch:

- http://d-jenkins.ubuntu-ci:8080/view/MAAS/job/utopic-adt-maas-manual/43/consoleFull shows both syslinux-common and syslinux-dev installed.
- http://d-jenkins.ubuntu-ci:8080/view/MAAS/job/trusty-adt-maas-manual/194/consoleFull shows only syslinux-common installed.

To post a comment you must log in.
Revision history for this message
Blake Rouse (blake-rouse) wrote :

lgtm!

review: Approve
Revision history for this message
Diogo Matsubara (matsubara) wrote :

Thanks Blake!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2014-06-20 16:52:55 +0000
3+++ debian/control 2014-06-20 17:08:01 +0000
4@@ -164,8 +164,8 @@
5 python-twisted,
6 python-zope.interface,
7 rsyslog,
8+ syslinux-dev | syslinux-common (<< 3:6.00~pre4+dfsg-5),
9 syslinux-common,
10- syslinux-dev | syslinux-common,
11 tgt,
12 ubuntu-cloudimage-keyring,
13 uuid-runtime,

Subscribers

People subscribed via source and target branches