Code review comment for lp:~matsubara/maas/invalid-syntax-fix

Revision history for this message
Julian Edwards (julian-edwards) wrote :

On Wednesday 19 September 2012 06:19:41 you wrote:
> On 19 Sep 2012 06:57, "John A Meinel" <email address hidden> wrote:
> > How did it get landed if it had a syntax error? nose was just not loading
>
> the file and not failing the test suite? Is there a way to teach nose that
> it should treat syntax errors as failures?
>
> Tests were failing, but landing to trunk is not gated on the test suite
> passing; Jenkins is set up to only tests things once they're in.
>
> Tarmac could do this for us, but we'd need to move it to a different host,
> or otherwise isolate it. IIRC, it's running on carob, under Julian's
> account.

It is. I want to use canonistack to run it, but that is currently too
unreliable and there's no way I am running arbitrary code under my account on
carob.

> Or, we could follow the Launchpad model and have a stable branch which
> feeds from trunk via Jenkins.

This is a joke? :)

« Back to merge proposal