Code review comment for lp:~matsubara/maas/invalid-syntax-fix
Revision history for this message
| Gavin Panella (allenap) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
On 19 Sep 2012 06:57, "John A Meinel" <email address hidden> wrote:
> How did it get landed if it had a syntax error? nose was just not loading
the file and not failing the test suite? Is there a way to teach nose that
it should treat syntax errors as failures?
Tests were failing, but landing to trunk is not gated on the test suite
passing; Jenkins is set up to only tests things once they're in.
Tarmac could do this for us, but we'd need to move it to a different host,
or otherwise isolate it. IIRC, it's running on carob, under Julian's
account.
Or, we could follow the Launchpad model and have a stable branch which
feeds from trunk via Jenkins.