Merge lp:~matsubara/launchpad/724727-single-line-inline-editor into lp:launchpad

Proposed by Diogo Matsubara
Status: Merged
Approved by: Diogo Matsubara
Approved revision: no longer in the source branch.
Merged at revision: 13317
Proposed branch: lp:~matsubara/launchpad/724727-single-line-inline-editor
Merge into: lp:launchpad
Diff against target: 13 lines (+3/-0)
1 file modified
lib/canonical/launchpad/icing/style-3-0.css (+3/-0)
To merge this branch: bzr merge lp:~matsubara/launchpad/724727-single-line-inline-editor
Reviewer Review Type Date Requested Status
Benji York (community) code Approve
Review via email: mp+66089@code.launchpad.net

Commit message

[r=benji][bug=724727] Override YUI's margin-top value for the single-line inline editor (Fix bug 724727)

Description of the change

This branch fixes bug 724727 by overriding margin-top value for .yui3-skin-sam .yui3-ieditor-input class. With this change the single-line inline editor (e.g. recipe title, bug titles) shifts the page just a little bit to accommodate the edit box.

To post a comment you must log in.
Revision history for this message
Benji York (benji) wrote :

Looks good. Since we already have a lot of lazr-js CSS in LP, adding more is the best route we can take until the great merge comes.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/canonical/launchpad/icing/style-3-0.css'
2--- lib/canonical/launchpad/icing/style-3-0.css 2011-06-27 13:22:42 +0000
3+++ lib/canonical/launchpad/icing/style-3-0.css 2011-06-28 08:26:13 +0000
4@@ -955,6 +955,9 @@
5 .yui3-ieditor {
6 padding-right: 288px;
7 }
8+.yui3-skin-sam .yui3-ieditor-input {
9+ margin-top: 0;
10+}
11 h1 .yui3-ieditor-errors {
12 font-size: 12px;
13 }