Code review comment for lp:~matsubara/curtin/jenkins

Revision history for this message
Diogo Matsubara (matsubara) wrote :

> Looks fine, please do add something so subsequent and/or parallel runs of
> vmtest don't write to the same file.
>
> The rest is fine.

Hi Ryan,

I initially used the FileHandler mode='a' so the log would always be appended but then the log file was growing too much (and my initial intention was to have it collected by each jenkins job after the run). I like the idea of putting a date in the name so it'll be kept separate. Fixed.

Thanks for the review!

« Back to merge proposal