Code review comment for lp:~matsubara/charms/trusty/jenkins/jenkins-bundle

Revision history for this message
Cory Johns (johnsca) wrote :

Diogo,

Thank you for your work on this. I have finished my review and testing, and this looks good. It is now merged.

As an aside, to get Zuul to deploy without the `make installdeps` step (which I missed), I had to make a change, which I submitted as an MP against that charm: https://code.launchpad.net/~johnsca/charms/precise/zuul/install-403/+merge/278072 (in case anyone else runs into this issue).

review: Approve

« Back to merge proposal