Auto Package Testing

Code review comment for lp:~matsubara/auto-package-testing/custom-meta-data-prepare-testbed

  1. custom-meta-data-prepare-testbed
  2. Merge into trunk
Revision history for this message
Martin Pitt (pitti) wrote :

Just two little nitpicks:

 + METADATAFILE=$2

Should be quoted.

+ cat $METADATAFILE > $METADATA

Should be quoted and use cp.

Otherwise this LGTM.

Out of interest, what do you need this for? I'm asking because this whole lp:auto-package-testing thing will go away in the next cycle in favor of running adt-run directly (with adt-virt-{lxc,qemu}), so we need to fit your use case there, too.

Thanks!

review: Needs Fixing

« Back to merge proposal