Merge lp:~matiasb/launchpad-buildd/add-build-request-id into lp:launchpad-buildd
Proposed by
Matias Bordese
Status: | Merged |
---|---|
Merged at revision: | 372 |
Proposed branch: | lp:~matiasb/launchpad-buildd/add-build-request-id |
Merge into: | lp:launchpad-buildd |
Diff against target: |
101 lines (+50/-3) 2 files modified
lpbuildd/target/build_snap.py (+11/-1) lpbuildd/target/tests/test_build_snap.py (+39/-2) |
To merge this branch: | bzr merge lp:~matiasb/launchpad-buildd/add-build-request-id |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Colin Watson (community) | Approve | ||
Review via email: mp+366458@code.launchpad.net |
Commit message
Add build_request_id and build_request_
To post a comment you must log in.
This looks OK from a launchpad-buildd point of view, but I think you should get review from somebody who's authoritative for adding more keys to SNAPCRAFT_ IMAGE_INFO and hence to image-info in the snap manifest. Sergio? A store or snapd architect? Somebody like that ...