Merge lp:~matiasb/canonical-identity-provider/adding-2fa-acceptance-tests into lp:canonical-identity-provider/release

[Matias Bordese]

Added acceptance tests for two factor page.

Added acceptance tests for two factor page (username display, logout option).
Started work on acceptance actions framework/refactoring.

[Leo Arias (elopio)]

we are trying to get rid of this:
59 +from sst.actions import *
so you can either import sst.actions and then call sst.actions.go_to
or from sst.actions import go_to.

thank you.

review: Approve (code review)

[Natalia Bidart (nataliabidart)]

It looks great!

review: Approve

=== added directory 'identityprovider/tests/acceptance/shared/actions'
=== added file 'identityprovider/tests/acceptance/shared/actions/__init__.py'
=== added file 'identityprovider/tests/acceptance/shared/actions/subheader.py'
--- identityprovider/tests/acceptance/shared/actions/subheader.py	1970-01-01 00:00:00 +0000
+++ identityprovider/tests/acceptance/shared/actions/subheader.py	2012-11-01 21:04:21 +0000
@@ -0,0 +1,47 @@
+import sst.actions
+
+
+def _assert_full_name_in_account_link(full_name):
+    sst.actions.assert_text(_get_my_account_link(), full_name[:40])
+
+
+def _get_my_account_link():
+    return sst.actions.get_element(id='account-link')
+
+
+def _get_devices_link():
+    return sst.actions.get_element(id='devices-link')
+
+
+def _get_applications_link():
+    return sst.actions.get_element(id='applications-link')
+
+
+def _get_log_out_link():
+    return sst.actions.get_element(id='logout-link')
+
+
+def assert_log_in(full_name):
+    _assert_full_name_in_account_link(full_name)
+    _get_log_out_link()
+
+
+def assert_log_out():
+    sst.actions.fails(_get_my_account_link)
+    sst.actions.fails(_get_log_out_link)
+
+
+def go_to_account():
+    sst.actions.click_link(_get_my_account_link())
+
+
+def go_to_devices():
+    sst.actions.click_link(_get_devices_link())
+
+
+def go_to_applications():
+    sst.actions.click_link(_get_applications_link())
+
+
+def log_out():
+    sst.actions.click_link(_get_log_out_link())
 
=== added file 'identityprovider/tests/acceptance/shared/actions/two_factor.py'
--- identityprovider/tests/acceptance/shared/actions/two_factor.py	1970-01-01 00:00:00 +0000
+++ identityprovider/tests/acceptance/shared/actions/two_factor.py	2012-11-01 21:04:21 +0000
@@ -0,0 +1,5 @@
+import sst.actions
+
+
+def open_page():
+    sst.actions.go_to('/two_factor_auth')
 
=== added directory 'identityprovider/tests/acceptance/two_factor'
=== added file 'identityprovider/tests/acceptance/two_factor/check_username_display.py'
--- identityprovider/tests/acceptance/two_factor/check_username_display.py	1970-01-01 00:00:00 +0000
+++ identityprovider/tests/acceptance/two_factor/check_username_display.py	2012-11-01 21:04:21 +0000
@@ -0,0 +1,22 @@
+# Check two factor page displays the username, account and logout options.
+
+from u1testutils.sst import config
+
+import helpers
+
+from actions import (
+    subheader,
+    two_factor,
+)
+
+
+config.set_base_url_from_env()
+
+display_name = "Fred Jones"
+# Create an account and login.
+helpers.register_account(displayname=display_name)
+
+# Go to two factor auth page
+two_factor.open_page()
+# check subheader navbar displays user info
+subheader.assert_log_in(display_name)