Merge lp:~mathieu.poirier-deactivatedaccount/linaro-image-tools/linaro-image-tools into lp:linaro-image-tools/11.11

Proposed by Mathieu Poirier
Status: Rejected
Rejected by: Данило Шеган
Proposed branch: lp:~mathieu.poirier-deactivatedaccount/linaro-image-tools/linaro-image-tools
Merge into: lp:linaro-image-tools/11.11
Diff against target: 25 lines (+4/-4)
1 file modified
linaro_image_tools/media_create/android_boards.py (+4/-4)
To merge this branch: bzr merge lp:~mathieu.poirier-deactivatedaccount/linaro-image-tools/linaro-image-tools
Reviewer Review Type Date Requested Status
Mattias Backman Pending
Review via email: mp+105711@code.launchpad.net

Description of the change

Moving our builds to u-boot-linaro-stable and therefore don't need the special naming convention nor the different 'fat load' command.

To post a comment you must log in.
Revision history for this message
Mattias Backman (mabac) wrote :

Hi Mathieu,

I think you should add linaro-infrastructure to land this for you. :)

My opinion is that you should just drop specifying values for fatload_command and uimage_path since the defaults will be inherited from BoardConfig. And kill the comments about the need for custom values since that's not the case anymore.

Thanks,

Mattias

Revision history for this message
Данило Шеган (danilo) wrote :

This is now superseeded by https://code.launchpad.net/~mathieu.poirier/linaro-image-tools/linaro-image-tools.may15/+merge/105848

Thanks Mattias for taking a long anyway :)

Unmerged revisions

517. By Mathieu Poirier

Moving snowball to u-boot-linaro-stable, hence no need for special name schemes anymore

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'linaro_image_tools/media_create/android_boards.py'
--- linaro_image_tools/media_create/android_boards.py 2012-03-21 14:14:56 +0000
+++ linaro_image_tools/media_create/android_boards.py 2012-05-14 19:57:19 +0000
@@ -202,8 +202,8 @@
202 # Snowball uses a custom uboot:202 # Snowball uses a custom uboot:
203 # it uses "fat load" instead of fatload and203 # it uses "fat load" instead of fatload and
204 # needs uImage/uInitrd prefixed with /204 # needs uImage/uInitrd prefixed with /
205 fatload_command = 'fat load'205 fatload_command = 'fatload'
206 uimage_path = '/'206 uimage_path = ''
207 dtb_name = None207 dtb_name = None
208208
209209
@@ -218,8 +218,8 @@
218 # Snowball uses a custom uboot:218 # Snowball uses a custom uboot:
219 # it uses "fat load" instead of fatload and219 # it uses "fat load" instead of fatload and
220 # needs uImage/uInitrd prefixed with /220 # needs uImage/uInitrd prefixed with /
221 fatload_command = 'fat load'221 fatload_command = 'fatload'
222 uimage_path = '/'222 uimage_path = ''
223 dtb_name = None223 dtb_name = None
224224
225 @classmethod225 @classmethod

Subscribers

People subscribed via source and target branches