Code review comment for lp:~mathieu-julius/prestashoperpconnect/prestashoperpconnect-get-good-taxes-in-lines

The whole _add_order_extra_line seems redundant with what we have in the connector_ecommerce.

I think that you probably need to re-use most of what is done in connector_ecommerce (extracting / splitting the things in methods that you need to reuse).

Do you use this method? I can't find a single call to it.

By the way, for information, I started a refactoring of the code which add the extra order lines because 2 things bother me in the actual code:
 - it should not be part of the 'sale.order' model but rather use the ConnectorUnit mechanism
 - the temporary fields put in the record and then removed back really really hurt me
The branches are here:
https://code.launchpad.net/~openerp-connector-core-editors/openerp-connector/7.0-e-commerce-addons-refactor-so-extra-lines
https://code.launchpad.net/~openerp-connector-core-editors/openerp-connector/7.0-magentoerpconnect-refactor-so-extra-lines
https://code.launchpad.net/~openerp-connector-core-editors/openerp-connector/7.0-connector-mapper-refactor