Code review comment for lp:~matej-sekoranja/epics-base/ca-username-change

Revision history for this message
Andrew Johnson (anj) wrote :

Before merging this I think we would need to have an equivalent implementation for the CAS server so the PV Gateway can be made to support the newer version of the CA protocol. That does pose one problem though – the CAS doesn't do variable length arrays yet, it still only supports protocol revision 12 and you can't add this support without doing that first/as well. Murali Shankar from SLAC was supposed to be working on that, but I don't know how far he's got with it so I've just written to him to ask.

I would also agree with Ralph's points that this will need the client API documenting in the caRef.html manual and in the protocol documentation (which I haven't merged into the AppDevGuide yet so hold off on doing that for now), and it will need an entry in the Release Notes too.

On the positive side, the implementation does look pretty much like I expected it would have to when I talked to Susan about it several months ago. You can continue to commit changes to your development branch and push them to launchpad (just 'bzr push', it should remember the branch URL). This merge proposal will be updated when you do that, but we won't be notified about such changes automatically, so add a comment to the merge proposal page when you want us to take another look.

Thanks,

- Andrew

review: Needs Fixing

« Back to merge proposal