Merge lp:~martin-ohlson/linaro-image-tools/disk-info-bug-673410 into lp:linaro-image-tools/11.11

Proposed by Martin Ohlsson
Status: Merged
Merged at revision: 168
Proposed branch: lp:~martin-ohlson/linaro-image-tools/disk-info-bug-673410
Merge into: lp:linaro-image-tools/11.11
Diff against target: 32 lines (+5/-5)
1 file modified
linaro-media-create (+5/-5)
To merge this branch: bzr merge lp:~martin-ohlson/linaro-image-tools/disk-info-bug-673410
Reviewer Review Type Date Requested Status
Guilherme Salgado (community) Approve
Review via email: mp+41139@code.launchpad.net

Description of the change

Replace "sfdisk -l" with "fdisk -l".

Bug #673410.

Use "fdisk -l" to list the partiton tables in a more user friendly manner.

I haven't been able to run the script for test/verification. I'm waiting on the IT department to install Ubuntu on my company computer. This branch is proposed for merging because it contains a very trivial fix.

Regards,
Martin

To post a comment you must log in.
Revision history for this message
Guilherme Salgado (salgado) wrote :

Hi Martin,

This looks good and seems to work as expected. Thanks!

 review approve

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'linaro-media-create'
--- linaro-media-create 2010-11-09 20:48:16 +0000
+++ linaro-media-create 2010-11-18 08:49:53 +0000
@@ -145,14 +145,14 @@
145}145}
146146
147check_device() {147check_device() {
148 FDISK=$(sudo LC_ALL=C sfdisk -l 2>/dev/null | grep "Disk ${DEVICE}" | awk '{print $2}')148 FDISK=$(sudo LC_ALL=C fdisk -l 2>/dev/null | grep "Disk ${DEVICE}" | awk '{print $2}')
149149
150 if test "-$FDISK-" = "-$DEVICE:-"150 if test "-$FDISK-" = "-$DEVICE:-"
151 then151 then
152 echo ""152 echo ""
153 echo "I see..."153 echo "I see..."
154 echo "sudo sfdisk -l:"154 echo "sudo fdisk -l:"
155 sudo LC_ALL=C sfdisk -l 2>/dev/null | grep "Disk /dev/" --color=never155 sudo LC_ALL=C fdisk -l 2>/dev/null | grep "Disk /dev/" --color=never
156 echo ""156 echo ""
157 echo "mount:"157 echo "mount:"
158 LC_ALL=C mount | grep -v none | grep "/dev/" --color=never158 LC_ALL=C mount | grep -v none | grep "/dev/" --color=never
@@ -164,8 +164,8 @@
164 echo ""164 echo ""
165 echo "Are you sure? I Don't see [${DEVICE}], here is what I do see..."165 echo "Are you sure? I Don't see [${DEVICE}], here is what I do see..."
166 echo ""166 echo ""
167 echo "sudo sfdisk -l:"167 echo "sudo fdisk -l:"
168 sudo LC_ALL=C sfdisk -l 2>/dev/null| grep "Disk /dev/" --color=never168 sudo LC_ALL=C fdisk -l 2>/dev/null| grep "Disk /dev/" --color=never
169 echo ""169 echo ""
170 echo "mount:"170 echo "mount:"
171 LC_ALL=C mount | grep -v none | grep "/dev/" --color=never171 LC_ALL=C mount | grep -v none | grep "/dev/" --color=never

Subscribers

People subscribed via source and target branches